Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install android app #1

Merged
merged 5 commits into from
Feb 12, 2025

Conversation

tokou
Copy link

@tokou tokou commented Sep 7, 2024

Proposed changes

I took the liberty to do a few changes

  • Make sure the path can be passed as an env var
  • Make sure we can install both from zip file and from app file on iOS
  • Add some integration tests

Let me know what you think

@boranfrkn
Copy link
Owner

boranfrkn commented Sep 7, 2024

Looks good thanks a lot, we can merge I think. what you think @bartekpacia

@Fishbowler
Copy link

@boranfrkn If you merge this into your branch here, it should update the PR into Maestro, and we can look to getting it into the next major release

@boranfrkn boranfrkn merged commit 4f6def6 into boranfrkn:InstallAndroidApp Feb 12, 2025
6 checks passed
@dano709
Copy link

dano709 commented Feb 13, 2025

Proposed changes

I took the liberty to do a few changes

  • Make sure the path can be passed as an env var
  • Make sure we can install both from zip file and from app file on iOS
  • Add some integration tests

Let me know what you think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants