-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Replace id
input with more general header
parameter
#11
Conversation
📝 Terraform Plan→ Resource Changes: 1 to create, 0 to update, 1 to re-create, 1 to delete. ✨ Create
|
While that looks grand to me (in terms of resolving my request :-), I'd be inclined to go for a separate header argument that defaults to |
id
input with more general header
parameter
@simonblake-mp sorry this took forever! I decided to go for the breaking change after all since it seems like a more general solution that allows for proper customization without having two parameters that do the same thing :) |
Motivation
Fixes #8.
@simonblake-mp, I simply changed the name here. I'm not entirely sure what's the most elegant way to make it configurable. To limit the number of action inputs, having both
header
(or something like that) andid
seems a little overkill so maybe one should useheader
for both and get rid ofid
. For now, I don't want to introduce a breaking change though 👀