Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow skipping comment when planfile is empty #31

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

borchero
Copy link
Owner

@borchero borchero commented Dec 2, 2024

Motivation

Resolves #30.

Changes

  • Add a new skip-empty parameter

@borchero borchero self-assigned this Dec 2, 2024
@github-actions github-actions bot added the enhancement New feature or request label Dec 2, 2024
Copy link

github-actions bot commented Dec 2, 2024

📝 Terraform Plan

→ Resource Changes: 1 to create, 0 to update, 1 to re-create, 1 to delete.

✨ Create

local_file.another
+ content              = "Hello terraform-plan-comment!"
+ content_base64sha256 = (known after apply)
+ content_base64sha512 = (known after apply)
+ content_md5          = (known after apply)
+ content_sha1         = (known after apply)
+ content_sha256       = (known after apply)
+ content_sha512       = (known after apply)
+ directory_permission = "0777"
+ file_permission      = "0777"
+ filename             = "../another.txt"
+ id                   = (known after apply)

⚙️ Re-Create

local_file.test[0]
! content              = (sensitive value) # forces replacement
! content_base64sha256 = "ky+KUESlzgvMLeuw3XSV1vkbxOF5V8FyQJOgxHgpBCQ=" -> (known after apply)
! content_base64sha512 = "aJZGbh9jITISv2IG7ZGUUXicGZWE6qx0q+nliS0gv+j+pKarbxV6zulyZVNFRmFbSq37iOY1lZB1Gc2H5dTEBA==" -> (known after apply)
! content_md5          = "fc2c3e6607b6600bc920f94918923a0f" -> (known after apply)
! content_sha1         = "48abe23164c0b8257d86841e4c8f2514083243cd" -> (known after apply)
! content_sha256       = "932f8a5044a5ce0bcc2debb0dd7495d6f91bc4e17957c1724093a0c478290424" -> (known after apply)
! content_sha512       = "6896466e1f63213212bf6206ed919451789c199584eaac74abe9e5892d20bfe8fea4a6ab6f157acee97265534546615b4aadfb88e63595907519cd87e5d4c404" -> (known after apply)
! id                   = "48abe23164c0b8257d86841e4c8f2514083243cd" -> (known after apply)
  # (3 unchanged attributes hidden)

🗑️ Delete

local_file.test[1]
- content              = (sensitive value) -> null
- content_base64sha256 = "ky+KUESlzgvMLeuw3XSV1vkbxOF5V8FyQJOgxHgpBCQ=" -> null
- content_base64sha512 = "aJZGbh9jITISv2IG7ZGUUXicGZWE6qx0q+nliS0gv+j+pKarbxV6zulyZVNFRmFbSq37iOY1lZB1Gc2H5dTEBA==" -> null
- content_md5          = "fc2c3e6607b6600bc920f94918923a0f" -> null
- content_sha1         = "48abe23164c0b8257d86841e4c8f2514083243cd" -> null
- content_sha256       = "932f8a5044a5ce0bcc2debb0dd7495d6f91bc4e17957c1724093a0c478290424" -> null
- content_sha512       = "6896466e1f63213212bf6206ed919451789c199584eaac74abe9e5892d20bfe8fea4a6ab6f157acee97265534546615b4aadfb88e63595907519cd87e5d4c404" -> null
- directory_permission = "0777" -> null
- file_permission      = "0777" -> null
- filename             = "../test.txt" -> null
- id                   = "48abe23164c0b8257d86841e4c8f2514083243cd" -> null

→ because index [1] is out of range for count


Triggered by @borchero, Commit: 15ca3b6b813b7257857aba5c29155153f1e70d33

@borchero
Copy link
Owner Author

borchero commented Dec 2, 2024

@comozo wdyt about naming?

@comozo
Copy link

comozo commented Dec 2, 2024

@borchero That's perfect. Thank you very much.

@borchero borchero merged commit bcd8b87 into main Dec 3, 2024
5 checks passed
@borchero borchero deleted the option-no-changes branch December 3, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to Skip Attaching Plan on No Changes
2 participants