Skip to content

Commit

Permalink
do not return the rc from Archiver methods
Browse files Browse the repository at this point in the history
this is not needed and getting rid of it makes
the code / behaviour simpler to understand:

if a fatal error is detected, we throw an exception.

if we encounter something warning worthy, we emit and collect the warning.

in a few cases, we directly call set_ec to set the
exit code as needed, e.g. if passing it through
from a subprocess.

also:
- get rid of Archiver.exit_code
- assert that return value of archiver methods is None
- fix a print_warning call to use the correct formatting method
  • Loading branch information
ThomasWaldmann committed Dec 5, 2023
1 parent 5169d4e commit f2486e4
Show file tree
Hide file tree
Showing 4 changed files with 57 additions and 88 deletions.
Loading

0 comments on commit f2486e4

Please sign in to comment.