Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

append_only and prune interaction #1689

Closed
rakajack opened this issue Oct 6, 2016 · 2 comments
Closed

append_only and prune interaction #1689

rakajack opened this issue Oct 6, 2016 · 2 comments
Assignees
Milestone

Comments

@rakajack
Copy link

rakajack commented Oct 6, 2016

Is it safe to automatically run prune (from the safe client) on append_only repository?

Is there a protection from the following situation:

  1. Hacked client A with append_only access iterates over chunk id's from the cache and put() garbage to them.
  2. Client B with full access runs a prune command.
@enkore
Copy link
Contributor

enkore commented Oct 6, 2016

No, there is no protection for that. If hacked client A just deleted important archives and client B would prune after that, with full access and not in append-only mode, then the data will be gone. Your example is a bit more involved, but has the same effect - the old, valid data would be deleted through the prune.

Therefore if this process is automated, then there should be some checks done that the expected archives (IDs) are still in place, and that an archive check should be run. I guess we should say so in the docs if we don't do already.

@ThomasWaldmann ThomasWaldmann added this to the 1.0.8 (rc2?) milestone Oct 16, 2016
@ThomasWaldmann ThomasWaldmann self-assigned this Oct 18, 2016
ThomasWaldmann added a commit to ThomasWaldmann/borg that referenced this issue Oct 18, 2016
ThomasWaldmann added a commit to ThomasWaldmann/borg that referenced this issue Oct 19, 2016
ThomasWaldmann added a commit that referenced this issue Oct 19, 2016
add clarification about append-only mode, fixes #1689
@ThomasWaldmann
Copy link
Member

Fixed by #1744.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants