Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platformdirs >= 3.0.0 is ONLY required for macOS #7393

Closed
ThomasWaldmann opened this issue Feb 27, 2023 · 1 comment
Closed

platformdirs >= 3.0.0 is ONLY required for macOS #7393

ThomasWaldmann opened this issue Feb 27, 2023 · 1 comment
Assignees
Milestone

Comments

@ThomasWaldmann
Copy link
Member

ThomasWaldmann commented Feb 27, 2023

Every other platform is fine with platformdirs 2.x.x also.

We need to add a comment about this to our setup.cfg so linux packagers don't run into unnecessary troubles.

Background:

  • a major release number change indicates a breaking change
  • the breakage introduced in platformdirs 3.0.0 is only because the macOS config directory changed (which was a bug fix, the old location was wrong), so this likely breaks upgrades on macOS.
  • the config and other dirs for linux, bsd, windows did not change (AFAIK) by platformdirs 2.x.x -> 3.

https://github.com/platformdirs/platformdirs/blob/main/CHANGES.rst

@ThomasWaldmann
Copy link
Member Author

The reason for borg to require platformdirs >=3.0.0 (on macOS) is to save macOS users from one future breakage by just starting with the new config dir.

@ThomasWaldmann ThomasWaldmann self-assigned this Mar 1, 2023
ThomasWaldmann added a commit that referenced this issue Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant