Add --append-only to borg serve (1.0-maint)

[PlasmaPower]

Replaces #1228 which resolves #1168

[enkore]

I don't see any existing tests for borg serve, is that correct?

The RPC / serve part is tested via RemoteArchiverTestCase in borg.testsuite.archiver and the RemoteXXX tests in borg.testsuite.repository. An extension of RepositoryAppendOnlyTestCase (borg.testsuite.repository) would be sufficient (cf. RemoteRepositoryTestCase).

[PlasmaPower]

@enkore Great, makes sense! Thanks for the help.

[ThomasWaldmann]

Hmm, doesn't it make sense to test local and remote? The cmdline option could also be used for locally mounted stuff, maybe for slightly different reasons.

[PlasmaPower]

How's that latest commit for a start? Now I just need to test that --append-only will get translated into a repo created with that flag.

Also, I keep almost pushing my .eggs, is there any way to fix that? Shouldn't it be in the .gitignore?

[enkore]

Also, I keep almost pushing my .eggs, is there any way to fix that? Shouldn't it be in the .gitignore?

build/dist/borg.build/.dist etc. are all in the git ignore...?

[PlasmaPower]

$ git status
On branch serve-append-only
Your branch is up-to-date with 'origin/serve-append-only'.
Untracked files:
  (use "git add <file>..." to include in what will be committed)

        .eggs/

nothing added to commit but untracked files present (use "git add" to track)

$ cat .eggs/README.txt
This directory contains eggs that were downloaded by setuptools to build, test, and run plug-ins.

This directory caches those eggs to prevent repeated downloads.

However, it is safe to delete this directory.

[enkore]

Oi, didn't notice that. But yeah, they're here as well, it's just that my worktrees are littered with stuff.

Guess setup.py develop does that, since pip/tox don't use eggs afaik. Suppose I should use pip install -e . instead.

[PlasmaPower]

I think that's all the testing that should be done with the current testing infrastructure. Anything more? If not, I think this is ready to merge.

[ThomasWaldmann]

Search where the docs refer to append-only and add some words and an example how it can be used after your change.

[PlasmaPower]

Right, docs. Forgot about those. Should be good with the latest commit.

[ThomasWaldmann]

typo: "its"

[ThomasWaldmann]

let's see if github finds it also in the 2nd line.

[PlasmaPower]

Yep!

PlasmaPower added a commit to PlasmaPower/borg that referenced this issue 3 minutes ago
@PlasmaPower Add --append-only to borg serve

Also, I know it does from experience.

[enkore]

LGTM, merge after travis?

[ThomasWaldmann]

yes.

@PlasmaPower thanks for contributing. Visit bountysource after the issue is closed and claim.

also, feel free to add yourself to AUTHORS file.

[PlasmaPower]

Side note on fixing an issue in the commit message: if you do that from the beginning and you amend to the commit every amendment will stay on the issue page which clogs it up fast.

@ThomasWaldmann Glad I could help! I'll be looking to contribute more in the future, even on issues without bounties. This project is a lot better than just rsync, I'll be personally using it.

[PlasmaPower]

I made a linting mistake in the repository tests. Fixed, but Travis will have to run again.

[ThomasWaldmann]

@PlasmaPower ah, interesting note about the commit msg.

[codecov-io]

Current coverage is 82.64%

Merging #1229 into 1.0-maint will increase coverage by 0.01%

@@           1.0-maint      #1229   diff @@
===========================================
  Files             14         14          
  Lines           4243       4246     +3   
  Methods            0          0          
  Messages           0          0          
  Branches         745        745          
===========================================
+ Hits            3506       3509     +3   
  Misses           521        521          
  Partials         216        216          

Powered by Codecov. Last updated by 1242653...79df1bd

[PlasmaPower]

Travis is done, it passed.

[ThomasWaldmann]

@PlasmaPower you committed .egg stuff. We completely killed that from history, please try again.