-
-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix xxh64 related build #5937
fix xxh64 related build #5937
Conversation
8cce7d7
to
6a381ad
Compare
Codecov Report
@@ Coverage Diff @@
## 1.1-maint #5937 +/- ##
=============================================
- Coverage 80.00% 79.98% -0.03%
=============================================
Files 27 27
Lines 10479 10482 +3
Branches 2146 2146
=============================================
Hits 8384 8384
- Misses 1575 1579 +4
+ Partials 520 519 -1
Continue to review full report at Codecov.
|
7b3859e
to
1e88a85
Compare
@LocutusOfBorg please review! |
This needs some testing for the "system lib" as well as for the "use bundled code" case, see upper part of setup.py. |
Test cases performed:
|
the xxh64 lib is used by borg's "checksums" module, not by borg's "crypto" module. inspired by LocutusOfBorg's debian packaging patch.
no '.' needed, '' is enough.
1e88a85
to
3036027
Compare
@LocutusOfBorg thanks for testing, will merge after test CI has completed. |
@LocutusOfBorg this is inspired by your debian patch.
https://salsa.debian.org/debian/borgbackup/-/blob/master/debian/patches/bundled-xxhash.patch
changes:
also, i gave xxh64 0.8.1 a try and it worked, so i updated the bundled code.