Add pyproject.toml #6355
Merged
Add pyproject.toml #6355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This blocks borgbackup#6264 because black configuration is stored in pyproject.toml. See <https://black.readthedocs.io/en/stable/usage_and_configuration/the_basics.html#configuration-format> I copied this from <https://setuptools.pypa.io/en/latest/userguide/quickstart.html#basic-use>
When using pyproject.toml the parent of setup.py is not on sys.path by default. See <pypa/setuptools#3134>
setup_crypto.crypto_ext_kwargs needs pkgconfig to find OpenSSL
Codecov Report
@@ Coverage Diff @@
## master #6355 +/- ##
==========================================
+ Coverage 83.11% 83.19% +0.07%
==========================================
Files 38 38
Lines 10426 10426
Branches 2042 2042
==========================================
+ Hits 8666 8674 +8
+ Misses 1254 1246 -8
Partials 506 506
Continue to review full report at Codecov.
|
I am working on this. |
|
btw, for now please no bigger / fundamental changes to setup.py / setup.cfg. |
|
from the codeql workflow: Guess adding these lines before pip3 should fix it, can you try?: |
A bug in pip or possibly setuptools broke editable installs into the per-user directory for packages that have pyproject.toml See pypa/setuptools#3019
|
Another workaround would be to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This blocks #6264 because black configuration is stored in pyproject.toml.
See https://black.readthedocs.io/en/stable/usage_and_configuration/the_basics.html#configuration-format
I copied this from https://setuptools.pypa.io/en/latest/userguide/quickstart.html#basic-use