implement and use (text|binary)_to_json #7232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasWaldmann
force-pushed
the
json_b64
branch
from
2f9c2e4
to
c5ee7ad
Compare
Codecov Report
@@ Coverage Diff @@
## master #7232 +/- ##
==========================================
+ Coverage 83.49% 83.51% +0.01%
==========================================
Files 67 67
Lines 11551 11571 +20
Branches 2095 2096 +1
==========================================
+ Hits 9644 9663 +19
Misses 1355 1355
- Partials 552 553 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ThomasWaldmann
changed the title
This was referenced Jan 8, 2023
binary bytes: - json_key = <key>_b64 - json_value == base64(value) text (potentially with surrogate escapes): - json_key1 = <key> - json_value1 = value_text (s-e replaced by ?) - json_key2 = <key>_b64 - json_value2 = base64(value_binary) json_key2/_value2 is only present if value_text required replacement of surrogate escapes (and thus does not represent the original value, but just an approximation). value_binary then gives the original bytes value (e.g. a non-utf8 bytes sequence).
item: path, source, user, group for non-unicode stuff borg 1.2 had "bpath". now we have: path - unicode approximation (invalid stuff replaced by ?) path_b64 - base64(path_bytes) # only if needed source has the same issue as path and is now covered also. user and group are usually unicode or even pure ASCII, but we rather are cautious and cover them also.
ThomasWaldmann
force-pushed
the
json_b64
branch
from
1d4d5f4
to
491f898
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
binary bytes:
text (potentially with surrogate escapes):
json_key2/_value2 is only present if value_text required replacement of surrogate escapes (and thus does not represent the original value, but just an approximation).
value_binary then gives the original bytes value (e.g. a non-utf8 bytes sequence).