Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved GUI to clarify Passphrase Field (Issue #2193) #2200

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shreyamali01
Copy link

Description

This pull request improves the user interface while creating a new repository by providing clearer instructions for the passphrase field. The improvement here addresses the user confusion by explicitly stating the purpose of passphrase (for encryption).

Related Issue

Fixes #2193 - Clarifies the passphrase field when creating a new repository.

Motivation and Context

When creating a new repository in Vorta, the users were unclear about the purpose of passphrase field. This change explicitly states the purpose of passphrase. This is crucial because without this passphrase users cannot decrypt their backup.

How Has This Been Tested?

The changes were tested by :

  • Launching the "Create New Repository" dialog and verifying that the passphrase field is correctly labeled.
  • Ensuring tooltip now clearly states the importance of passphrase and recommends to store it.
  • Testing the GUI for proper layout and sectioning under new "Encryption" header.

Screenshots:

Before

Before

After

After

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.

@shreyamali01
Copy link
Author

@m3nu Could you please review this PR when possible. Thank you!

@m3nu
Copy link
Contributor

m3nu commented Feb 6, 2025

The window seems very wide and this PR makes minor changes to label that will result in all translations to be updated. And the new title that's added "Encryption" isn't marked for translation at all.

So all in all, I'm not sure the extra work for translators will be worth this change of adding a title and a long sentence at the bottom.

@shreyamali01
Copy link
Author

@m3nu Thank you for your feedback!

I have made the following changes based on your feedback :

  • Removed the 'Encryption' title completely.
  • The labels remain unchanged, so no additional translation work will be required.
  • Updated the tooltip, to clarify that the passphrase is required to access the backup later.

These changes will improve the clarity without compromising on the layout and additional translation work.

Screenshot

Updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants