Added support for Pushover Hook for notifications #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to implement yet another monitoring hook! I'll have a look at this after the 1.9.0 release—which I'm currently trying to avoid scope creep on so that it's released sometime this century. 😄 |
witten
reviewed
Nov 8, 2024
witten
reviewed
Nov 9, 2024
| ) | ||
|
|
||
|
|
||
| def test_ping_monitor_start_state_backup_default_message_with_priority_high_declared_expire_and_retry_delared_success(): |
There was a problem hiding this comment.
This one too: IMO it's not just the success you care about but the fact that expire and retry are ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR aims to add support for Pushover notifications.
I've updated the documentation, list of supported integrations on borgmatic website homepage and have included various tests.
Pushover uses two keys. A user key and an application key. User keys are how you are authenticated to your Pushover account. Application keys are how Pushover knows which application to post the message to. Applications can be though of as threads, or topics.
I've included support for all of the API options that Pushover has.
Please let me know if there are any changes I should make.