Skip to content

Commit

Permalink
Merge remote-tracking branch 'upstream/main' into undecorate-typecheck
Browse files Browse the repository at this point in the history
  • Loading branch information
borisfom committed Jun 13, 2024
2 parents a5caddb + a01fa6d commit ea50c5e
Show file tree
Hide file tree
Showing 107 changed files with 3,732 additions and 9,243 deletions.
35 changes: 35 additions & 0 deletions .github/ISSUE_TEMPLATE/dev_container_bug_report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
---
container pulled on date: mm/dd/yyyy
name: Dev container - Bug report
about: Create a report to help us improve
title: ''
labels: bug
assignees: ''

---

**Describe the bug**

A clear and concise description of what the bug is.

**Steps/Code to reproduce bug**

Please list *minimal* steps or code snippet for us to be able to reproduce the bug.

A helpful guide on on how to craft a minimal bug report http://matthewrocklin.com/blog/work/2018/02/28/minimal-bug-reports.


**Expected behavior**

A clear and concise description of what you expected to happen.

**Environment overview (please complete the following information)**

- Environment location: Docker
- Method of install: Please specify exact commands you used to install.
- If method of install is [Docker], provide `docker pull` & `docker run` commands used

**Additional context**

Add any other context about the problem here.
Example: GPU model
23 changes: 0 additions & 23 deletions .github/scripts/slackHelper.sh

This file was deleted.

21 changes: 19 additions & 2 deletions .github/workflows/_test_template.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,16 @@ on:
conclusion:
description: Conclusion of main test step
value: ${{ jobs.main.outputs.conclusion }}

log:
description: Last 2000 characters of the test step's log
value: ${{ jobs.main.outputs.log }}
jobs:
main:
runs-on: ${{ inputs.RUNNER }}
timeout-minutes: ${{ inputs.TIMEOUT }}
outputs:
conclusion: ${{ steps.main.conclusion }}
log: ${{ steps.main.outputs.log }}
container:
image: nemoci.azurecr.io/nemo_container_${{ github.run_id }}
options:
Expand All @@ -50,7 +53,21 @@ jobs:
- name: Checkout repository
uses: actions/checkout@v4
- id: main
run: ${{ inputs.SCRIPT }}
name: Run main script
run: |
set +e
(
set -e
${{ inputs.SCRIPT }}
) 2> >(tee err.log)
EXIT_CODE=$?
echo "log=$(tail -c 2000 err.log | base64 -w 0)" >> "$GITHUB_OUTPUT"
exit $EXIT_CODE
- uses: "NVIDIA/NeMo/.github/actions/cancel-workflow@main"
if: failure() && inputs.IS_OPTIONAL == false
- name: after_script
Expand Down
Loading

0 comments on commit ea50c5e

Please sign in to comment.