Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root log is not propagated to console #3295

Closed
mkykadir opened this issue Apr 14, 2022 · 4 comments · Fixed by #3302
Closed

Root log is not propagated to console #3295

mkykadir opened this issue Apr 14, 2022 · 4 comments · Fixed by #3302
Assignees
Labels
type-bug Things don't work as they were intended to, or the way they were intended to work doesn't make sense

Comments

@mkykadir
Copy link
Contributor

Even following config, logs are not displayed on console; since #3243

logging:
  root:
    level: Info
    console: true
    file: log/root.log
@mkykadir mkykadir self-assigned this Apr 14, 2022
@mkykadir mkykadir added the type-bug Things don't work as they were intended to, or the way they were intended to work doesn't make sense label Apr 14, 2022
@linked0
Copy link
Contributor

linked0 commented Apr 14, 2022

I have used the additive: true for the problem, it is just a workaround tho.

@mkykadir
Copy link
Contributor Author

I have used the additive: true for the problem, it is just a workaround tho.

Yeah, I don't know if this is an undocumented change in behavior but;
this causes

@mkykadir
Copy link
Contributor Author

Likewise, setting the root logger as additive most likely
means child loggers should be additive too,
hence propagating all options make more sense.

I believe there was a behavioral change thus, additive is required by default now. We can close this or reconsider. What are your thoughts? @hewison-chris

@hewison-chris
Copy link
Contributor

hewison-chris commented Apr 15, 2022

Likewise, setting the root logger as additive most likely
means child loggers should be additive too,
hence propagating all options make more sense.

I believe there was a behavioral change thus, additive is required by default now. We can close this or reconsider. What are your thoughts? @hewison-chris

Perhaps the default should be additive so that it behaves as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Things don't work as they were intended to, or the way they were intended to work doesn't make sense
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants