Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dtext to HEAD #3243

Merged
merged 2 commits into from
Mar 31, 2022
Merged

Update dtext to HEAD #3243

merged 2 commits into from
Mar 31, 2022

Conversation

Geod24
Copy link
Collaborator

@Geod24 Geod24 commented Mar 31, 2022

Support for FunctionOrigin is coming but there's a couple simplifications needed.

This ensure a consistent behavior as the Logger gets more configurable.
Currently 'console' is disabled to avoid a ConsoleAppender,
however a future change could make the settings take a list of Appenders.
@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #3243 (affe800) into v0.x.x (c349f8e) will increase coverage by 33.92%.
The diff coverage is 69.23%.

@@             Coverage Diff             @@
##           v0.x.x    #3243       +/-   ##
===========================================
+ Coverage   54.63%   88.56%   +33.92%     
===========================================
  Files         332      166      -166     
  Lines       35815    17030    -18785     
===========================================
- Hits        19567    15082     -4485     
+ Misses      16248     1948    -14300     
Flag Coverage Δ
integration 29.87% <63.63%> (+0.20%) ⬆️
unittests 87.60% <69.23%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/agora/utils/Log.d 62.26% <63.63%> (ø)
source/agora/test/Base.d 80.99% <100.00%> (+0.71%) ⬆️
source/agora/common/VibeTask.d 0.00% <0.00%> (-86.67%) ⬇️
source/agora/common/FileBasedLock.d 0.00% <0.00%> (-72.73%) ⬇️
source/agora/node/Runner.d 40.52% <0.00%> (-15.04%) ⬇️
source/agora/consensus/BlockStorage.d 68.90% <0.00%> (-11.31%) ⬇️
source/agora/consensus/protocol/Nominator.d 91.23% <0.00%> (-0.72%) ⬇️
source/agora/consensus/EnrollmentManager.d 96.85% <0.00%> (-0.32%) ⬇️
source/agora/node/FullNode.d 75.85% <0.00%> (-0.31%) ⬇️
...dules/vibe.d/textfilter/vibe/textfilter/markdown.d
... and 168 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c349f8e...affe800. Read the comment docs.

Copy link
Contributor

@hewison-chris hewison-chris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@hewison-chris hewison-chris merged commit d360fd7 into bosagora:v0.x.x Mar 31, 2022
@Geod24 Geod24 deleted the dtext branch March 31, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants