Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported LDC to v1.23 + v1.22 #1134

Merged
merged 1 commit into from
Sep 4, 2020
Merged

Conversation

Geod24
Copy link
Collaborator

@Geod24 Geod24 commented Aug 24, 2020

No description provided.

@Geod24
Copy link
Collaborator Author

Geod24 commented Aug 24, 2020

And it uncovered a bad bug!

@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #1134 into v0.x.x will increase coverage by 1.45%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           v0.x.x    #1134      +/-   ##
==========================================
+ Coverage   77.30%   78.76%   +1.45%     
==========================================
  Files          84       86       +2     
  Lines        8042     8150     +108     
==========================================
+ Hits         6217     6419     +202     
+ Misses       1825     1731      -94     
Flag Coverage Δ
#integration 40.29% <ø> (?)
#unittests 77.10% <ø> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/agora/utils/Log.d 63.79% <0.00%> (-4.73%) ⬇️
source/agora/utils/Test.d 95.78% <0.00%> (-0.82%) ⬇️
source/agora/common/TransactionPool.d 95.86% <0.00%> (-0.07%) ⬇️
source/agora/consensus/data/ConsensusParams.d 100.00% <0.00%> (ø)
source/agora/test/ManyValidators.d
source/agora/common/FileBasedLock.d 72.72% <0.00%> (ø)
source/agora/test/QuorumShuffle.d 85.89% <0.00%> (ø)
source/agora/node/main.d 61.53% <0.00%> (ø)
source/agora/consensus/validation/Block.d 97.91% <0.00%> (+<0.01%) ⬆️
source/agora/test/Base.d 84.44% <0.00%> (+0.09%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 786497e...7d9fde4. Read the comment docs.

@@ -3,18 +3,29 @@
"targetType": "executable",
"targetPath": "build",
"dflags": [ "-i" ],
"lflags": [ "-lsodium" ],
"libs": [ "sodium" ],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this

@Geod24
Copy link
Collaborator Author

Geod24 commented Sep 4, 2020

Green, nice !
So just three things:

  1. Remove the non-postfixed libs, it's redundant;
  2. Fix the formatting of the array of versions to be somewhat readable;
  3. Squash;

And we're g2g

@ferencdg ferencdg force-pushed the update-ldc branch 4 times, most recently from 4662976 to 7bd5147 Compare September 4, 2020 04:03
@Geod24
Copy link
Collaborator Author

Geod24 commented Sep 4, 2020

Great, thanks!

@Geod24 Geod24 merged commit 8e5291d into bosagora:v0.x.x Sep 4, 2020
@Geod24 Geod24 deleted the update-ldc branch September 4, 2020 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant