Add ability to provide DNS seeds #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrejMitrovic
force-pushed
the
dns-seeds
branch
from
b858e88
to
80bc15e
Compare
TrustHenry
approved these changes
Jun 21, 2019
It will be reused in a later commit.
AndrejMitrovic
force-pushed
the
dns-seeds
branch
2 times, most recently
from
5699fee
to
29da5b3
Compare
|
Rebased against v0.x.x. |
Geod24
approved these changes
Jun 30, 2019
AndrejMitrovic
force-pushed
the
dns-seeds
branch
from
26df439
to
339f8ca
Compare
|
@Geod24 Fixed and squashed. |
|
Btw, I wasn't sure whether we can provide a list of initial nodes and also DNS seeds in the same config |
You didn't modify the call site tho |
Geod24
reviewed
Jun 30, 2019
source/agora/node/Network.d
Outdated
| } | ||
|
|
||
| /// try to discover the network until we found | ||
| /// all the validator nodes from our quorum set. | ||
| public void discover () | ||
| { | ||
| logInfo("Resolving DNS from %s", this.dns_seeds); | ||
| this.addAddresses(resolveDnsSeeds(this.dns_seeds)); |
There was a problem hiding this comment.
Also what that in a if (this.dns_seeds.length)
We don't want to make DNS seed mandatory for the moment, do we ?
It's currently part of a separate config field to cleanly separate between Agora nodes and DNS seeds. It may later be merged into a common section if necessary.
|
Rebased. |
Geod24
approved these changes
Jul 1, 2019
AndrejMitrovic
added
the
type-feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure we can test this in the repo until we implement integration testing. However a few manual test-runs did work with a DNS seed node.