Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry: Remove realm from zone list with data #3318

Merged
merged 1 commit into from
May 6, 2022
Merged

Registry: Remove realm from zone list with data #3318

merged 1 commit into from
May 6, 2022

Conversation

mkykadir
Copy link
Contributor

@mkykadir mkykadir commented May 6, 2022

Realm will not have actual registry record data but will act as a
seeder for both validator and flash zones.

Towards #2874

Realm will not have actual registry record data but will act as a
seeder for both validator and flash zones.
@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #3318 (6acb4ec) into v0.x.x (a00e567) will increase coverage by 0.28%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           v0.x.x    #3318      +/-   ##
==========================================
+ Coverage   87.77%   88.05%   +0.28%     
==========================================
  Files         165      164       -1     
  Lines       17082    16975     -107     
==========================================
- Hits        14993    14947      -46     
+ Misses       2089     2028      -61     
Flag Coverage Δ
integration 42.89% <ø> (+13.65%) ⬆️
unittests 87.77% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/agora/node/Registry.d 77.29% <ø> (ø)
source/agora/node/FullNode.d 70.83% <0.00%> (-1.20%) ⬇️
source/agora/consensus/protocol/Nominator.d 91.29% <0.00%> (-0.36%) ⬇️
source/agora/consensus/state/Ledger.d 88.85% <0.00%> (-0.33%) ⬇️
source/agora/node/main.d
source/agora/script/Engine.d 97.49% <0.00%> (+0.14%) ⬆️
source/agora/test/Base.d 80.89% <0.00%> (+0.19%) ⬆️
source/agora/network/Manager.d 76.99% <0.00%> (+0.31%) ⬆️
source/agora/consensus/BlockStorage.d 79.50% <0.00%> (+2.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a00e567...6acb4ec. Read the comment docs.

@omerfirmak omerfirmak merged commit dc79da4 into bosagora:v0.x.x May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants