Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add config params #71

Merged
merged 43 commits into from
Jan 13, 2025
Merged

Feature/add config params #71

merged 43 commits into from
Jan 13, 2025

Conversation

ant-u
Copy link
Collaborator

@ant-u ant-u commented Dec 5, 2024

First: merge feature/adapt_tests_for_warning

Here, the params -continue_on_error and -errors_as_warnings are introduced.

Also, some more testcases are added.

ant-u added 23 commits April 2, 2024 10:56
@ant-u
changed each test to also check for warnings and specified which warn…
a3cac85 
…ing must be displayed

Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
implemented change requests
183d2b7 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
Merge branch 'main' into feature/adapt_tests_for_warning
473b6ab 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
linter issues
55e2230 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
added location of check
d21b4de 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
added check class
6ca9be7 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
added test for xml conformity
2da0559 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
added check for validating xml with scheme, output not yet processed …
01d8ef7 
…though

Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
created whole check out of validation function. introduced success an…
7bf022e 
…d failure messages

Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
Merge branch 'main' into feature/adapt_tests_for_warning
0a47e98 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
corrected double code
03279cb 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
moved check to extra file
9dc4761 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
fixed imports and whitespaces
abf0c4d 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
changed if structure of _check method
8687856 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
changed tests to all fullfill scheme version
3d57102 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
changed test data with source-file attribute to version 4
dbef936 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
added case for package.xml version 4
cd379e5 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
removed todo
9330eb2 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
adapted wrong test
3ece023 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
moved version checking and xml tree conversion to package.py
bc4fabf 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
refactor of schema check
9716639 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
fixed bug
bab6691 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
added new args for config
b393418 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
723 670 93% 90% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 740e6d0 by action🐍

ant-u added 6 commits December 5, 2024 10:16
@ant-u
added functionality for config options
e002704 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
added scheme 2 test
7020bf3 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
added tests for all scheme versions
8baa2fd 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
added negative, violating tests for every scheme
7b05817 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
adapted tests to scan for schemacheck as well
e2ac79c 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
added online schema aquiration
f9c46d5 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
ant-u added 7 commits December 9, 2024 09:28
@ant-u
changed used xml validation files with online files, still need a fal…
396e73d 
…lback to offline

Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
changed readme due to updates on code
7f7d0f5 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
changed readme
2cbfca5 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
changed content of arguments help
62ff892 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
added lazy schema request
e3c6c89 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
saving validation schema to reduce requests
19415cd 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
deleted local shema files, rewrote schema_check cases and adapted sch…
125c185 
…ema checks to not be downwards compatible

Signed-off-by: Anton Utz <uta5fe@bosch.com>
ct2034
ct2034 requested changes Dec 9, 2024
View reviewed changes
schemas/package_common.xsd Outdated Show resolved Hide resolved
src/ros_license_toolkit/checks.py Outdated Show resolved Hide resolved
src/ros_license_toolkit/license_checks/license_in_code_check.py Outdated Show resolved Hide resolved
src/ros_license_toolkit/license_checks/schema_check.py Outdated Show resolved Hide resolved
ant-u added 2 commits December 12, 2024 09:11
@ant-u
Resolved merge conflicts
711d56a 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
implemented suggestions again
fd38aff 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u ant-u requested a review from ct2034 December 12, 2024 08:42
@ant-u ant-u self-assigned this Dec 12, 2024
@ant-u ant-u marked this pull request as ready for review December 12, 2024 08:44
ct2034
ct2034 requested changes Dec 16, 2024
View reviewed changes
src/ros_license_toolkit/license_checks/schema_check.py Outdated Show resolved Hide resolved
src/ros_license_toolkit/license_checks/schema_check.py Outdated Show resolved Hide resolved
src/ros_license_toolkit/license_checks/schema_check.py Show resolved Hide resolved
src/ros_license_toolkit/license_checks/schema_check.py Outdated Show resolved Hide resolved
src/ros_license_toolkit/license_checks/schema_check.py Outdated Show resolved Hide resolved
src/ros_license_toolkit/main.py Outdated Show resolved Hide resolved
test/systemtest/test_separate_pkgs.py Outdated Show resolved Hide resolved
ant-u added 5 commits January 9, 2025 10:38
@ant-u
implemented suggestions
cf48bfd 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
added fail case for no connection & adapted readme
56e7873 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
linter issues
0205104 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
fixing documentation bug
24350fe 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
documentation fix
740e6d0 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u ant-u requested a review from ct2034 January 13, 2025 14:42
@ant-u
Copy link
Collaborator Author

ant-u commented Jan 13, 2025

Error in documentation_test was that the ros_license_toolkit -h command inserts line breaks when operated with subprocess.Popen(). Therefore I added the same line break in the documentation. Another (future) possibility would be to ignore these exact kinds of line breaks. For now it would just add unnecessary overhead.

@ct2034 ct2034 merged commit 84540e2 into main Jan 13, 2025
12 checks passed
@ct2034 ct2034 deleted the feature/add_config_params branch January 13, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ct2034 ct2034 ct2034 approved these changes

Assignees

@ant-u ant-u

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ant-u @ct2034