fix: support for raw data #89
Conversation
Bug 981245: node-red-contrib-ctrlx-automation: No support for RAW data
This reverts commit e644408.
please adapt to new behaviour and enable again.
|
@krauskopf : "skipped unittest 'ctrlx-datalayer-subscribe: Error Handling', please adapt to new behaviour and enable again. |
|
changed: the nodes now return the data as-it-is with type 'raw', if not valid JSON (server failure or raw data) |
|
I am missing a comment in the changelog of the readme.md |
|
@krauskopf: using default VS Code formatting, so please adopt or "hide white space" |
Can you make your VSCode config to consider the .editorconfig settings? |
|
@krauskopf : It's not the .editorconfig, it's your used formatting extension which differs from current default one and Prettier, maybe you're using a deprecated one. I tried to restore the previous formatting, but please think about to update. Thank you. |
| * @returns {object} - The parsed javascript object. | ||
| * @memberof CtrlxDatalayer | ||
| * @throws {SyntaxError} On invalid JSON objects. | ||
| */ | ||
| static _parseData(data) { | ||
|
|
||
| // We expect JSON.parse to fail here for invalid JSON |
There was a problem hiding this comment.
// It may happen, that JSON.parse may fail here for invalid JSON. But we catch this in the calling function.
lib/CtrlxDatalayerV2.js
Outdated
|
|
||
| // We expect 200 on success | ||
| if (res.statusCode !== 200) { | ||
| callback(CtrlxProblemError.fromHttpResponse(res, data)); | ||
| return; | ||
| } | ||
|
|
||
| // Try to parse the data | ||
| // Try to parse the data, else we return the binary buffer (raw) |
There was a problem hiding this comment.
Why don't we use the "content-type" in the response header to distinguish between binary data ("octet-stream") and JSON data ("application/json") in the first place?
Returning raw/data if json parsing fails could be a fallback strategy, but actually it is an error of the server to send wrong encoded data.
Pseudo-Code:
if (respons.header("content-type") == "application/json") {
payload = CtrlxDatalayer._parseData(data);
} else {
payload = {
type: 'raw',
value: buffer,
}
}
Bug 981245: node-red-contrib-ctrlx-automation: No support for RAW data