Fix delay_ms in readme and const at reg_data for Write method #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d, because introduce invalid conversion errors at the compilation time
cr0wg4n
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying this driver in my esp8266 microcontroller and I've detect these errors, the readme documentation shows
delay_msis in thebme280_devstruct but is not, instead ofdelay_msisdelay_us.At the compilation time this error arrives me:
error: invalid conversion from 'int8_t (*)(uint8_t, uint8_t*, uint32_t, void*)I've review the code and I've detect the
consttype of variable is in thereg_datapointer atbme280_write_fptr_ttypedef for write method.I hope this PR help us, thank you so much.