Launch with Terminal: Add fallback to PowerShell on exception #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
needs further translation to other langs!
github-actions
bot
added
translation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello there!
As you are a first time contributor please read our Code of Conduct as well our Contribution Guideline.
RedyAu
changed the title
RedyAu
commented
Jun 24, 2024
| mode: ProcessStartMode.normal, runInShell: true); | ||
| List<String> launchWslHome = ['wsl', '-d', distribution, '--cd', '~']; | ||
| try { | ||
| await Process.start('wt', launchWslHome); |
There was a problem hiding this comment.
Had to remove runInShell otherwise exception is not provided to our process. I don't know if this has other unwanted side effects, but it does launch wt correctly if it is installed. Please confirm.
|
Sorry, hungarian lang should be pushed to a different PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#252
#184