fix: Add missing Embed::batch_size implementation
#378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcjmurillo
changed the title
Embed::batch_size implementationEmbed::batch_size implementation
|
Indeed, nice find! Thank you for your contribution |
timonv
approved these changes
Oct 11, 2024
This was referenced Oct 11, 2024
Closed
Closed
Closed
Closed
Merged
timonv
added a commit
that referenced
this pull request
Oct 11, 2024
## 🤖 New release * `swiftide`: 0.13.2 -> 0.13.3 (✓ API compatible changes) * `swiftide-core`: 0.13.2 -> 0.13.3 * `swiftide-indexing`: 0.13.2 -> 0.13.3 (✓ API compatible changes) * `swiftide-macros`: 0.13.2 -> 0.13.3 * `swiftide-integrations`: 0.13.2 -> 0.13.3 (✓ API compatible changes) * `swiftide-query`: 0.13.2 -> 0.13.3 <details><summary><i><b>Changelog</b></i></summary><p> ## `swiftide` <blockquote> ## [0.13.3](v0.13.2...v0.13.3) - 2024-10-11 ### Bug fixes - [2647f16](2647f16) *(deps)* Update rust crate text-splitter to 0.17 ([#366](#366)) - [d74d85b](d74d85b) *(indexing)* Add missing `Embed::batch_size` implementation ([#378](#378)) - [95f78d3](95f78d3) *(tree-sitter)* Compile regex only once ([#371](#371)) ````text Regex compilation is not cheap, use a static with a oncelock instead. ```` ### Miscellaneous - [0000000](0000000) Update Cargo.toml dependencies **Full Changelog**: 0.13.2...0.13.3 </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). --------- Co-authored-by: Timon Vonk <timonv@gmail.com>
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transformers::Embedwas missing theEmbed::batch_sizeimplementation forBatchableTransformer, causing the pipeline to always use the default batch size when using this transformer.