feat(agents): Rename CommandError::FailedWithOutput to CommandError::NonZeroExit
#484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r::NonZeroExit` Better describes what is going on. I.e. `rg` exits with 1 if nothing is found, tests generally do the same if they fail.
This was referenced Dec 17, 2024
Closed
Merged
timonv
pushed a commit
that referenced
this pull request
Dec 23, 2024
## 🤖 New release * `swiftide`: 0.14.4 -> 0.15.0 (⚠️ API breaking changes) * `swiftide-agents`: 0.14.4 -> 0.15.0 (✓ API compatible changes) * `swiftide-core`: 0.14.4 -> 0.15.0 (⚠️ API breaking changes) * `swiftide-macros`: 0.14.4 -> 0.15.0 * `swiftide-integrations`: 0.14.4 -> 0.15.0 (✓ API compatible changes) * `swiftide-indexing`: 0.14.4 -> 0.15.0 * `swiftide-query`: 0.14.4 -> 0.15.0 (✓ API compatible changes) ###⚠️ `swiftide` breaking changes ``` --- failure module_missing: pub module removed or renamed --- Description: A publicly-visible module cannot be imported by its prior path. A `pub use` may have been removed, or the module may have been renamed, removed, or made non-public. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/module_missing.ron Failed in: mod swiftide::agents, previously in file /tmp/.tmpqenghN/swiftide/src/lib.rs:108 ``` ###⚠️ `swiftide-core` breaking changes ``` --- failure enum_variant_added: enum variant added on exhaustive enum --- Description: A publicly-visible enum without #[non_exhaustive] has a new variant. ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/enum_variant_added.ron Failed in: variant CommandError:NonZeroExit in /tmp/.tmpm3E1mt/swiftide/swiftide-core/src/agent_traits.rs:29 variant CommandError:NonZeroExit in /tmp/.tmpm3E1mt/swiftide/swiftide-core/src/agent_traits.rs:29 --- failure enum_variant_missing: pub enum variant removed or renamed --- Description: A publicly-visible enum has at least one variant that is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/enum_variant_missing.ron Failed in: variant CommandError::FailedWithOutput, previously in file /tmp/.tmpqenghN/swiftide-core/src/agent_traits.rs:29 variant CommandError::FailedWithOutput, previously in file /tmp/.tmpqenghN/swiftide-core/src/agent_traits.rs:29 ``` <details><summary><i><b>Changelog</b></i></summary><p> ## `swiftide` <blockquote> ## [0.15.0](v0.14.4...v0.15.0) - 2024-12-23 ### New features - [a1b9a2d](a1b9a2d) *(query)* Ensure concrete names for transformations are used when debugging (#496) - [7779c44](7779c44) *(query)* Ensure query pipeline consistently debug logs in all other stages too - [55dde88](55dde88) *(query)* Debug full retrieved documents when debug mode is enabled (#495) - [66031ba](66031ba) *(query)* Log query pipeline answer on debug (#497) ### Miscellaneous - [d255772](d255772) *(agents)* Rename `CommandError::FailedWithOutput` to `CommandError::NonZeroExit` (#484) ````text Better describes what is going on. I.e. `rg` exits with 1 if nothing is found, tests generally do the same if they fail. ```` - [0000000](0000000) Update Cargo.toml dependencies **Full Changelog**: 0.14.4...0.15.0 </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better describes what is going on. I.e.
rgexits with 1 if nothing isfound, tests generally do the same if they fail.