scollector generates wrong key without FQDN

[R-Sommer]

Hi,

I run a vsphere environment without DNS. This leads scollector to generate an incomplete key i.e. vsphere.guest.mem.used,guest=vsa1,host=192 (I'd assume the idea behind is to cut the domain part from FQDN).

[gbrayut]

This is due to the clean function in the bosun.org/util package. You can add FullHost = true in scollector.toml to disable the short names and always use FQDNs.

@kylebrandt thoughts on adding an IP check to the util function? probably shouldn't string split if it is a valid IPv4 address.

[R-Sommer]

@gbrayut I added FullHost = true and now I have complete ip addresses. However, there is a new error:

error: collectors.go:256: Invalid tagset discovered: {disk=ESXi1-BackupDS,host=}. Skipping datapoint. Added from: vsphere.go:104

Do you want me to keep this issue open regarding IP check? Shall I open a new issue for this new error?