Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: don't try to clean IP addresses. Also don't clean twice on Set #1902

Merged
merged 1 commit into from
Sep 12, 2016
Merged

util: don't try to clean IP addresses. Also don't clean twice on Set #1902

merged 1 commit into from
Sep 12, 2016

Conversation

gbrayut
Copy link
Contributor

@gbrayut gbrayut commented Sep 7, 2016

No description provided.

@gbrayut
Copy link
Contributor Author

gbrayut commented Sep 7, 2016

Addresses part of #1862

Tested locally and it works using ipv4 address as hostname. IPv6 addresses don't use .s so they won't have the same split issue.

@captncraig
Copy link
Contributor

lgtm

@gbrayut gbrayut merged commit 19f8e01 into master Sep 12, 2016
@gbrayut gbrayut deleted the util branch September 12, 2016 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR - Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gbrayut @captncraig