cmd/bosun: shorten the action page URLs #1126
Merged
+278
−236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents proxies from refusing to relay because the HTTP header is too large. This is done by reducing the length of the requesting page's URL. But since bosun communicates data between controllers via the URL, we now introduce a new key/value store to perform that exchange. The other implementations for this communication aren't sibling-sibling, they are parent-child. I didn't find a good way to do sibling-sibling communication, and this is pretty clear, so I think it's a good choice. fixes #1053
| keys = [search.key]; | ||
| } | ||
| $location.search('key', null); | ||
| $scope.setKey('action-keys', keys); |
There was a problem hiding this comment.
Do we need to set $scope.keys in this block?
There was a problem hiding this comment.
Nope. The changing of $location.search above changes the URL which re-renders this controller at the end of the digest cycle.
captncraig
added a commit
that referenced
this pull request
Jul 2, 2015
cmd/bosun: shorten the action page URLs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents proxies from refusing to relay because the HTTP header is
too large. This is done by reducing the length of the requesting page's
URL. But since bosun communicates data between controllers via the URL, we
now introduce a new key/value store to perform that exchange.
The other implementations for this communication aren't sibling-sibling,
they are parent-child. I didn't find a good way to do sibling-sibling
communication, and this is pretty clear, so I think it's a good choice.
fixes #1053