cmd/bosun: Add metric stats to host API #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,809 @@ | |||
| package sched // import "bosun.org/cmd/bosun/sched" | |||
There was a problem hiding this comment.
thanks for making a new file :)
kylebrandt
force-pushed
the
hostVitals
branch
from
7825b3d to
96e00f5
Compare
| slog.Error(err) | ||
| } | ||
| processHostIncidents(host, states, silences) | ||
| for _, ts := range icmpTimeOutTags { |
There was a problem hiding this comment.
this is a lot of iteration. I each iteration over hosts, you iterate over all tags for a lot of metrics. Perhaps we can turn those arrays into maps by host before we enter the main loop.
and additional fixes from code review
kylebrandt
added a commit
that referenced
this pull request
Oct 22, 2015
cmd/bosun: Add metric stats to host API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.