Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/bosun: annotate support #1610

Merged
merged 1 commit into from
Feb 22, 2016
Merged

cmd/bosun: annotate support #1610

merged 1 commit into from
Feb 22, 2016

Conversation

kylebrandt
Copy link
Member

No description provided.

@kylebrandt
Copy link
Member Author

yiwa6ucoka

if err := annotateBackend.InitBackend(); err != nil {
return err
}
web.AddRoutes(router, "/api", []backend.Backend{annotateBackend}, false, false)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this way of doing it a lot. What are the last two bool parameters for? Mostly out of curiosity.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm. read the code.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we gonna try to get the ui working at some point?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enable the independent UI, and use local dev files when doing so

On Mon, Feb 22, 2016 at 11:56 AM, Craig Peterson notifications@github.com
wrote:

In cmd/bosun/web/web.go
#1610 (comment):

  • // Annotations
  • if schedule.Conf.AnnotateEnabled() {
  •   var err error
    
  •   index := schedule.Conf.AnnotateIndex
    
  •   if index == "" {
    
  •       index = "annotate"
    
  •   }
    
  •   annotateBackend, err = backend.NewElastic(schedule.Conf.AnnotateElasticHosts, index)
    
  •   if err != nil {
    
  •       return err
    
  •   }
    
  •   if err := annotateBackend.InitBackend(); err != nil {
    
  •       return err
    
  •   }
    
  •   web.AddRoutes(router, "/api", []backend.Backend{annotateBackend}, false, false)
    

I like this way of doing it a lot. What are the last two bool parameters
for? Mostly out of curiosity.


Reply to this email directly or view it on GitHub
https://github.com/bosun-monitor/bosun/pull/1610/files#r53654814.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI does work, but I don't intend to just import the UI into bosun, Bosun will integrate with it using it's own UI.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was thinking it might be nice if your ui has direct query/filter/ raw viewing support.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, approaching this incremently and thinking of it as probably a "preview" feature when we release

@captncraig
Copy link
Contributor

LGTM

@kylebrandt kylebrandt merged commit c7a0e31 into master Feb 22, 2016
@captncraig captncraig deleted the annotate branch February 24, 2016 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants