cmd/scollector: bugfix - datapoint validation #1856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mathpl
commented
Aug 9, 2016
mathpl
commented
- TagSet.Clean() validates cleaned key/value are not empty.
- DataPoint.Clean() is also called when quickly dequeuing the datapoint channel.
- Data points deemed unclean increment scollector.collect.discarded instead of scollector.collect.dropped.
| @@ -131,6 +135,13 @@ func InitChan(tsdbhost *url.URL, root string, ch chan *opentsdb.DataPoint) error | |||
| slock.Unlock() | |||
| return | |||
| }) | |||
| Set("collect.discarded", Tags, func() (i interface{}) { | |||
| slock.Lock() | |||
There was a problem hiding this comment.
I don't think you even need to lock if you are using the atomic operations. You could use atomic.LoadInt64 and not need locks at all. I wish we had done all these stats like that from the start.
There was a problem hiding this comment.
want me to move all those to atomic.* ? I'd be happy to.
There was a problem hiding this comment.
Yes please. I'm going to merge this for now, but if you wanted to do that in a seperate pr it would be appreciated. Thanks!
gbrayut
added a commit
that referenced
this pull request
Aug 16, 2016
The add function in cmd/scollector/collectors/collectors.go uses host= to indicate that tag should be omitted See https://github.com/bosun-monitor/bosun/blob/ac7f667fa1e649b877b77bfab7f2a643f5d8e615/cmd/scollector/collectors/collectors.go#L292
gbrayut
added a commit
that referenced
this pull request
Aug 16, 2016
The add function in cmd/scollector/collectors/collectors.go uses host= to indicate that tag should be omitted See https://github.com/bosun-monitor/bosun/blob/ac7f667fa1e649b877b77bfab7f2a643f5d8e615/cmd/scollector/collectors/collectors.go#L292
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.