Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/tsdbrelay: fix http: proxy error: EOF due to mixing Content-Encoding headers #1889

Merged
merged 1 commit into from
Aug 26, 2016

Conversation

gbrayut
Copy link
Contributor

@gbrayut gbrayut commented Aug 25, 2016

No description provided.

@gbrayut
Copy link
Contributor Author

gbrayut commented Aug 25, 2016

Confirmed this fixes the periodic http: proxy error: EOF and http: proxy error: net/http: request canceled errors we were seeing. They were caused by collectors sending non-gzip requests to tsdbrelay, which then added the encoding header and forwarded to another tsdbrelay instance, causing an EOF error, which then canceled the request (see the recently added tsdbrelay.*.error metrics for more details). Those datapoints were only being saved in our primary cluster, but now they are flowing to the failover cluster as well.

I'll merge this after testing for a few more hours to make sure there are no other issues.

@gbrayut gbrayut merged commit 9f7f8bf into master Aug 26, 2016
@gbrayut gbrayut deleted the tsdbrelay branch August 26, 2016 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant