-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't fetch indices , add indices to cache, and add esmonthly func #1931
Conversation
Currently if the time series is missing it errors inside ESDateHistrogram when it can't get the expected time series in the result. This result gets cached. Before when it would error on no indices in |
I think counting the resulting shards and erroring when there were no shards that matched will get the result I want. However, it depends on the following PR olivere/elastic#373 Alternatively, I could go for the date math method mentioned in #1926 (comment) . But only if |
9d96453
to
cf1315b
Compare
cf1315b
to
719508b
Compare
note: forgot to fmt, force pushed the fmt. |
} | ||
return str, nil | ||
return fmt.Sprintf("%v\n%s", r.Indices, b), nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably use string(b)
here. Don't want [42 31 13]
in you key.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
additionally, what does the source have that causes it to be a different key? What varies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ask because it surprises me that something like getting a cache key even has a possibility of erroring.
fixes #1926 |
No description provided.