Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ackTime to incident filters #2014

Merged
merged 2 commits into from
Feb 10, 2017
Merged

Add ackTime to incident filters #2014

merged 2 commits into from
Feb 10, 2017

Conversation

kylebrandt
Copy link
Member

This lets you show incidents that were acknowledged more than X time ago. A useful view to scan for things in ack that maybe need to be resolved.

@kylebrandt kylebrandt requested a review from gbrayut February 10, 2017 17:16
@gbrayut
Copy link
Contributor

gbrayut commented Feb 10, 2017

two comments, otherwise LGTM

docs/usage.md Outdated
range specified in Grafana. For example, <code>ackTime:<24h</code> shows incidents that were acknowledged more than 24 hours ago.</td>
</tr>
<tr>
<td><code>ackTime:(true|false)</code></td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this suppose to be ack: instead of ackTime: ?

docs/usage.md Outdated
@@ -88,7 +88,15 @@ The open incident filter supports joining terms in `()` as well as the `AND`, `O
<th>Description</th>
</tr>
<tr>
<td><code>ack:(true|false)</code></td>
<td><code>ackTime:[<|>](1d)</code></td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like it is not indented correctly

@kylebrandt kylebrandt merged commit 8866155 into master Feb 10, 2017
@kylebrandt kylebrandt deleted the ackAgoFilter branch February 10, 2017 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants