cmd/scollector: add NETDataProviderForSqlServer metrics #2225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickCraver
reviewed
Mar 2, 2018
| tags := opentsdb.TagSet{"name": name, "id": "0"} | ||
| // Not a 100% on counter / gauge here, may see some wrong after collecting more data. PerSecond being a counter is expected | ||
| // however since this is a PerfRawData table | ||
| Add(&md, "dotnet.sqlprov.hard_connects", v.HardConnectsPerSecond, tags, metadata.Counter, metadata.Connection, descWinDotNetSQLHardConnectsPerSecond) |
There was a problem hiding this comment.
FWIW, I'd just call this dotnet.sql.<thing>
NickCraver
reviewed
Mar 2, 2018
| const ( | ||
| descWinDotNetSQLHardConnectsPerSecond = "A counter of the number of actual connections per second that are being made to servers." | ||
| descWinDotNetSQLHardDisconnectsPerSecond = "A counter of the number of actual disconnects per second that are being made to servers." | ||
| descWinDotNetSQLNumberOfActiveConnectionPoolGroups = "The number of unique connection strings." |
There was a problem hiding this comment.
"The number of unique connection pool groups." - it's not exactly 1:1 with Connection strings, it just happens to be for us. For example, when using AD auth and impersonation it'd be 1 connection string but 1 pool per identity.
NickCraver
reviewed
Mar 2, 2018
| descWinDotNetSQLNumberOfActiveConnectionPools = "The number of active connection pools." | ||
| descWinDotNetSQLNumberOfActiveConnections = "The number of connections currently in-use." | ||
| descWinDotNetSQLNumberOfFreeConnections = "The number of connections currently available for use." | ||
| descWinDotNetSQLNumberOfInactiveConnectionPoolGroups = "The number of unique connection strings waiting for pruning." |
There was a problem hiding this comment.
"The number of unique connection pool groups waiting for pruning." (see above comment)
NickCraver
reviewed
Mar 2, 2018
| descWinDotNetSQLNumberOfInactiveConnectionPools = "The number of inactive connection pools." | ||
| descWinDotNetSQLNumberOfNonPooledConnections = "The number of connections that are not using connection pooling." | ||
| descWinDotNetSQLNumberOfPooledConnections = "The number of connections that are managed by the connection pooler." | ||
| descWinDotNetSQLNumberOfReclaimedConnections = "The number of connections we reclaim from GCed external connections." |
There was a problem hiding this comment.
Would phrase these as: "The number of connections reclaimed from GCed external connections."
NickCraver
reviewed
Mar 2, 2018
| descWinDotNetSQLNumberOfPooledConnections = "The number of connections that are managed by the connection pooler." | ||
| descWinDotNetSQLNumberOfReclaimedConnections = "The number of connections we reclaim from GCed external connections." | ||
| descWinDotNetSQLNumberOfStasisConnections = "The number of connections currently waiting to be made ready for use." | ||
| descWinDotNetSQLSoftConnectsPerSecond = "A counter of the number of connections we get from the pool per second." |
There was a problem hiding this comment.
"The number of connections opened from the pool per second."
NickCraver
approved these changes
Mar 2, 2018
| descWinDotNetSQLNumberOfReclaimedConnections = "The number of connections we reclaim from GCed external connections." | ||
| descWinDotNetSQLNumberOfStasisConnections = "The number of connections currently waiting to be made ready for use." | ||
| descWinDotNetSQLSoftConnectsPerSecond = "A counter of the number of connections we get from the pool per second." | ||
| descWinDotNetSQLSoftDisconnectsPerSecond = "A counter of the number of connections we return to the pool per second." |
There was a problem hiding this comment.
"The number of connections closed and returned to the pool per second."
captncraig
approved these changes
Mar 2, 2018
captncraig
reviewed
Mar 2, 2018
| } | ||
| var md opentsdb.MultiDataPoint | ||
| // We add the values of multiple pools that share a PID, this could cause some counter edge cases | ||
| pidToRows := make(map[string][]int) |
There was a problem hiding this comment.
Please explain what the counters represent in the value arrays. Are they fixed length or variable?
| // is skipped when adding metrics | ||
| for _, idx := range rows[1:] { | ||
| skipIndex[idx] = true | ||
| dst[rows[0]].HardDisconnectsPerSecond += dst[idx].HardDisconnectsPerSecond |
There was a problem hiding this comment.
let's store dst[rows[0]] as a variable to clean up the repetition here.
There was a problem hiding this comment.
And probably dst[idx] too.
| } | ||
| var name string | ||
| // Extract PID from the Name field, which is odd in this class | ||
| m := dotNetSQLPIDRegex.FindStringSubmatch(v.Name) // Index to remote actuator pylons to check for review quality |
| } | ||
| pidToRows[m[1]] = append(pidToRows[m[1]], i) | ||
| } | ||
| skipIndex := make(map[int]bool) |
There was a problem hiding this comment.
please describe the purpose of this, and what true/false indicate
clinta
pushed a commit
to clinta/bosun
that referenced
this pull request
Mar 9, 2018
pradeepbbl
pushed a commit
to pradeepbbl/bosun
that referenced
this pull request
Mar 21, 2018
michep
pushed a commit
to michep/bosun
that referenced
this pull request
Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.