cmd/scollector: Added Elastic config options #2257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @chriswhite199, I'm going to see if I can help this PR along since I'd also like this functionality in scollector. |
PeterGrace
approved these changes
May 26, 2018
There was a problem hiding this comment.
I've been running this PR in my environment for the last four hours and it has worked as expected, asides from the fact that the elasticsearch collector has an assumption that it should only get index data from masters, which isn't feasible in all scenarios, but will require a separate issue/PR that is definitely not in scope of this change.
LGTM +1 on merge
|
@kylebrandt @captncraig if either of you fine humans would be so kind as to also give your +1 before someone smacks the merge button, that'd be fantabulous. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address: #2256