Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API routes should never serve home page as html. #2284

Merged
merged 1 commit into from
Jul 24, 2018
Merged

API routes should never serve home page as html. #2284

merged 1 commit into from
Jul 24, 2018

Conversation

captncraig
Copy link
Contributor

anything under /api will 404 now if not matched another route.

Should fix a couple of crazy cases where html is returned to api routes, and shenanigans result.

Also a few encodeuricomponent calls needed in the front-end.

@captncraig captncraig merged commit 2c398c6 into master Jul 24, 2018
@kylebrandt kylebrandt deleted the api404 branch January 17, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant