Upgraded go version in the Dockerfile for bosun build #2359
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Bosun compilation by running
bosun/cmd/bosun/docker/docker.sh
currently fails:This happens because the build is using
go1.7
, whilesort.Slice
was introduced in1.8
, see https://golang.org/pkg/sort/#SliceThis commit contains the
golang
version upgrade1.7
→1.8
needed for compilation to proceed.@kylebrandt @captncraig please have a look.
Perhaps, it makes sense to upgrade to an even higher version, not just to
1.8
.