Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded go version in the Dockerfile for bosun build #2359

Merged
merged 2 commits into from
Jan 14, 2019

Conversation

grzkv
Copy link
Contributor

@grzkv grzkv commented Dec 16, 2018

The Bosun compilation by running bosun/cmd/bosun/docker/docker.sh currently fails:

> ./docker.sh
> ...
> Step 14/14 : RUN go run build/build.go     && bosun -version     && scollector -version     && tsdbrelay -version
> building bosun
> go install -ldflags -X bosun.org/_version.VersionSHA=03ad93d1efaf9a14d95f9a8da7e9cf08974ae67c -X bosun.org/_version.VersionDate=20181215204533 bosun.org/cmd/bosun
# bosun.org/cmd/bosun/database
cmd/bosun/database/migrate.go:109: undefined: sort.Slice
2018/12/15 20:46:33 exit status 2
exit status 1

This happens because the build is using go1.7, while sort.Slice was introduced in 1.8, see https://golang.org/pkg/sort/#Slice

This commit contains the golang version upgrade 1.71.8 needed for compilation to proceed.

@kylebrandt @captncraig please have a look.

Perhaps, it makes sense to upgrade to an even higher version, not just to 1.8.

@grzkv
Copy link
Contributor Author

grzkv commented Dec 20, 2018

According to #2319 will upgrade to v1.11. Thanks, @pradeepbbl for pointing this out.

@grzkv
Copy link
Contributor Author

grzkv commented Jan 12, 2019

Updated version as discussed. Please, merge if no objections.

@kylebrandt kylebrandt merged commit 1225b14 into bosun-monitor:master Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants