cmd/scollector: pull index data from non-master hosts #2368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was done because this can blow up the tag count on opentsdb. So by only sending from one host "master", this limits the number of datapoints for each cluster to one host at a time. An option could be added to make it so it collects them from all of them, but don't want to make that the default behavior. |
|
@kylebrandt Thank you for explanation. I added option to force collecting cluster-wide metrics(including indices) when current node isn't master. By default it retains old behavior. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #2259.
I think, there's no reason to require target node to be master - correct me, if I'm wrong. I have setup, where masters have no HTTP interface for querying statistics, so ability to collect data from non-master hosts is crucial.