Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Get rid of redundant logback dependency #398

Merged
merged 2 commits into from
Jun 2, 2024

Conversation

flipp5b
Copy link
Contributor

@flipp5b flipp5b commented Jun 1, 2024

For now, core depends on logback. It's pretty uncommon for a library to depend on a concrete slf4j implementation (usually, it's up to the end application to decide which implementation to use).

This PR removes redundant logback dependency from the core and adds it to examples.

P.S. I'm new to Mill, so that may be not an idiomatic way to solve the issue 😅

build.sc Show resolved Hide resolved
@ex0ns
Copy link
Contributor

ex0ns commented Jun 2, 2024

Thanks for the PR, I those changes should solve this specific issue.
By the way, you can test by running a few examples using the following command:

`mill -i __.examples.jvm[_].console`
new EchoBot("<Your telegram bot token>").run

And this works similarly for monix (replace jvm with monixjvm, ziojvm and catsjvm)

@flipp5b
Copy link
Contributor Author

flipp5b commented Jun 2, 2024

I've tested examples as follows:

mill examples.cats3jvm[_].run EchoBot <token>

I can't spot any issues, at least logging works.

@ex0ns ex0ns merged commit aabcf33 into bot4s:main Jun 2, 2024
1 check passed
@ex0ns
Copy link
Contributor

ex0ns commented Jun 2, 2024

@flipp5b this is available in release 5.8.1 that should soon be available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants