Skip to content

Commit

Permalink
FIX(client): Fix memory leak in CertWizard::importCert
Browse files Browse the repository at this point in the history
BIO_set_close with BIO_NOCLOSE argument leads to memory leaks here

Closes mumble-voip#6603
  • Loading branch information
botanegg committed Oct 11, 2024
1 parent cb01bfa commit c02eab3
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/mumble/Cert.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,6 @@ Settings::KeyPair CertWizard::importCert(QByteArray data, const QString &pw) {
int ret = 0;

mem = BIO_new_mem_buf(data.data(), static_cast< int >(data.size()));
Q_UNUSED(BIO_set_close(mem, BIO_NOCLOSE));
pkcs = d2i_PKCS12_bio(mem, nullptr);
if (pkcs) {
ret = PKCS12_parse(pkcs, nullptr, &pkey, &x509, &certs);
Expand Down

0 comments on commit c02eab3

Please sign in to comment.