Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use discord.js as dependency and use its client types #129

Merged
merged 4 commits into from
Oct 2, 2022
Merged

feat: use discord.js as dependency and use its client types #129

merged 4 commits into from
Oct 2, 2022

Conversation

maybeanerd
Copy link
Member

@maybeanerd maybeanerd commented Oct 2, 2022 •
edited
Loading

BREAKING: drop support for discord.js v13 v12 and lower

@maybeanerd maybeanerd added dependencies Pull requests that update a dependency file hacktoberfest-accepted hacktoberfest-accepted labels Oct 2, 2022
@maybeanerd maybeanerd linked an issue Oct 2, 2022 that may be closed by this pull request
Add Support for discord.js v14 #90
Closed
@maybeanerd
Copy link
Member Author

maybeanerd commented Oct 2, 2022 •
edited
Loading

I still want to test if it would work to not bundle it as peer dependency, but as dev dependency - does it require discord.js to be built in the parent repo? It only uses types, so I would hope not. That could keep the package a lot smaller

@maybeanerd maybeanerd force-pushed the feat/add-discord.js-v14-support branch from c0a11a9 to 924f434 Compare October 2, 2022 11:03
@maybeanerd maybeanerd marked this pull request as ready for review October 2, 2022 11:10
@maybeanerd
Copy link
Member Author

tested it and we do not need to install the discord.js version in the parent project. even more, we can still use discord.js v13, which is nice. still a breaking change though

maybeanerd
maybeanerd commented Oct 2, 2022
View reviewed changes
src/main.ts Outdated Show resolved Hide resolved
@maybeanerd maybeanerd force-pushed the feat/add-discord.js-v14-support branch from 924f434 to 121997a Compare October 2, 2022 11:16
@maybeanerd
feat: install discord.js as dev dependency and directly use its clien…
b74e031 
…t types

BREAKING: drop support for discord.js v12 and lower

Tested typing using discord.js v13 and it was compatible
@maybeanerd maybeanerd force-pushed the feat/add-discord.js-v14-support branch from 121997a to b74e031 Compare October 2, 2022 11:16
@maybeanerd maybeanerd removed the hacktoberfest-accepted hacktoberfest-accepted label Oct 2, 2022
@maybeanerd
Copy link
Member Author

maybeanerd commented Oct 2, 2022 •
edited
Loading

removed hacktoberfest-accepted label until merged, because I think it's meant to be applied only after merging/approving the PR

@Andre601
Copy link

Andre601 commented Oct 2, 2022 •
edited
Loading

The PR only needs one of these:

  • Approving review
  • hacktoberfest-accepted label
  • Merge

So, if the PR is merged or you give it an approving review should it already count (Just needs to mature 7 days after this).

More info: https://hacktoberfest.com/participation/#pr-mr-details

@maybeanerd maybeanerd changed the title feat: install discord.js as peer dependency and directly use its client types feat: use discord.js as dependency and use its client types Oct 2, 2022
@maybeanerd
Copy link
Member Author

yeah that's the reason I removed the label, because hacktoberfest already thought this PR was approved and that's not true 😁

@maybeanerd maybeanerd merged commit 8574573 into main Oct 2, 2022
@maybeanerd maybeanerd deleted the feat/add-discord.js-v14-support branch October 2, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Support for discord.js v14
2 participants
@maybeanerd @Andre601