Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for default_action on element #36 #60

Merged
merged 1 commit into from
Mar 10, 2018

Conversation

sgasser
Copy link
Contributor

@sgasser sgasser commented Mar 6, 2018

@codecov
Copy link

codecov bot commented Mar 6, 2018

Codecov Report

Merging #60 into master will increase coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #60      +/-   ##
============================================
+ Coverage      69.4%   69.57%   +0.16%     
- Complexity      367      368       +1     
============================================
  Files            33       33              
  Lines           902      907       +5     
============================================
+ Hits            626      631       +5     
  Misses          276      276
Impacted Files Coverage Δ Complexity Δ
src/Extensions/Element.php 87.17% <100%> (+1.88%) 15 <1> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 554540b...ea2a252. Read the comment docs.

@mpociot
Copy link
Member

mpociot commented Mar 6, 2018

Do we have to change the API version of the facebook API to make use of this field?

@sgasser
Copy link
Contributor Author

sgasser commented Mar 6, 2018

Nope, it works with the API version 2.6 👍

@mpociot mpociot merged commit c81a96a into botman:master Mar 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants