Initial commit of DynamoDB batch writer #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is similar to what boto2 does in terms of the interface with a few internal details changed: * Keep a single buffer of puts and deletes. This simplifies the logic of when to send requests. It also sends the requests in the order they were called. In boto2, puts were always sent before deletes(). This shouldn't affect the semantics though because you can't put/delete the same object in a batch request. * Immediately handle unprocessed items in the next batch. boto2 would keep these and flush them only at __exit__. This meant you could have unbounded growth of unprocessed items. Perf is about the same as boto2.
| RequestItems={self._table_name: self._items_buffer}) | ||
| unprocessed_items = response['UnprocessedItems'] | ||
|
|
||
| if unprocessed_items and unprocessed_items[self._table_name]: |
There was a problem hiding this comment.
Is it guaranteed that the table_name is in the unprocessed_items? I would be wary of accessing it directly. Probably would use a get().
There was a problem hiding this comment.
Yes. From the API docs, the unprocessed items is a map of table name to unprocessed items. Given we control the request and can guarantee that we're only ever adding items from a single table, then we know that if the unprocessed items is not empty, it has to come from the table we specified in the originating request.
|
Looks good. Code is pretty clean. I had a couple comments. Otherwise, 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to what boto2 does in terms of
the interface with a few internal details changed:
the logic of when to send requests. It also sends the
requests in the order they were called. In boto2, puts
were always sent before deletes(). This shouldn't affect
the semantics though because you can't put/delete the same
object in a batch request.
would keep these and flush them only at exit. This meant
you could have unbounded growth of unprocessed items.
Perf is about the same as boto2.
cc @kyleknap @mtdowling