Support latest resource model version. #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds support for the latest version of the JSON description files for resources. The following has changed: 1. An action's `.path` has been moved into `.resource.path` if a resource is present. If it is present, then a path outside of the resource is no longer valid. This fixes #33. 2. Sub-resources previously defined with either `hasOne` or `hasMany` are now defined with a single `belongsTo` key. The internal Boto 3 representation, however, remains the same and is accessed via `resource.references`. As a result of the format changes, I had to update the internal resource model, adjust the search path behavior for actions and update various tests that made assumptions about the older format. I also discovered that we were using a mix of old and new files for different services, so this change includes updates to EC2 and Glacier so that all resources are using the new format. With this change, we no longer support the older format.
danielgtaylor
added
the
enhancement
|
Looks good. 🚢 As a future PR, we should have integration tests that catch these type of regressions where we actually create resources for specific services like s3 and sqs and performs some actions using these resources. |
danielgtaylor
added a commit
that referenced
this pull request
Dec 3, 2014
Support latest resource model version. Fixes #34.
danielgtaylor
added a commit
that referenced
this pull request
Dec 3, 2014
This adds integration tests that exercise previously untested functionality, specifically this adds the following to the existing describe calls: * Create and delete remote resources * Call actions to put and get data from remote resources * Handle low-level responses from a service * Exercise low-level waiters (to be replaced with high-level waiters) * Access data attributes of pre-loaded resources with no `load` method The last item would have prevented #33. This PR is related to #34, which fixed the underlying issue that this test would have caught. The full integration test suite now takes around 20-30 seconds on my machine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for the latest version of the JSON description files
for resources. The following has changed:
.pathhas been moved into.resource.pathif a resourceis present. If it is present, then a path outside of the resource is
no longer valid. This fixes Trying to access SQS message body throws an exception as of boto3 versions 0.0.3 and 0.0.2 #33.
hasOneorhasManyare nowdefined with a single
belongsTokey. The internal Boto 3 representation,however, remains the same and is accessed via
resource.references.As a result of the format changes, I had to update the internal resource
model, adjust the search path behavior for actions and update various tests
that made assumptions about the older format.
I also discovered that we were using a mix of old and new files for different
services, so this change includes updates to EC2 and Glacier so that all
resources are using the new format. With this change, we no longer support
the older format.
cc @jamesls, @kyleknap