Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a lock file for requirements-docs.txt #4171

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

jonathan343
Copy link
Contributor

@jonathan343 jonathan343 commented Jun 19, 2024

This PR uses the pip-compile command from pip-tools to generate a lock file for requirments-docs.txt. This was generated in Python 3.8 virtual environment.

NOTE:
The following urllib3 requirements were added to requirements-docs.txt to force the same version constraints as botocore when generating the requirements-docs-lock.txt:

# Avoid urllib3 2.x below Python 3.10
urllib3<2.0 ; python_version < "3.10"

This specifically becomes an issue when using Python 3.8 since Sphinx has a transitive dependency on the latest version of urllib3 and botocore will require urllib3>=1.25.4,<1.27.

docs/README.rst Outdated Show resolved Hide resolved
@jonathan343 jonathan343 merged commit a9066f5 into boto:develop Jul 8, 2024
39 checks passed
aws-sdk-python-automation added a commit that referenced this pull request Jul 8, 2024
* release-1.34.141:
  Bumping version to 1.34.141
  Add changelog entries from botocore
  Add a lock file for requirements-docs.txt (#4171)
hswong3i pushed a commit to alvistack/boto-boto3 that referenced this pull request Jul 10, 2024
* Add a lock file for requirements-docs.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants