Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update developer guide to include account ID based endpoints #4446

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

alexgromero
Copy link
Contributor

@alexgromero alexgromero commented Feb 19, 2025

This PR adds documentation to the Credentials developer guide to include information about account ID based endpoints.

References:

Screenshots:

Screenshot 2025-02-19 at 10 43 06 AM Screenshot 2025-02-19 at 10 43 18 AM Screenshot 2025-02-19 at 10 43 31 AM

* AWS IAM Identity Center credential provider
* Shared credential file (``~/.aws/credentials``)
* AWS config file (``~/.aws/config``)
* Container credential provider
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we should document this one yet since it's not actually supported by the service, but we support it. What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, that is true. We have added the ability to source account_id from this provider though so it will work when/if they decide to send an account ID back. If we remove it now, how will we know when to add back it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point, it is a supported provider, I guess we should leave it in for now

@alexgromero alexgromero requested a review from SamRemis February 21, 2025 19:00
@alexgromero alexgromero changed the title Update credentials developer guide to include account ID Update developer guide to include account ID based endpoints Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants