The extra_args was not properly relayed within MultipartDownloader #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| downloader.download_file( | ||
| 'bucket', 'key', 'filename', len(response_body), extra_args) | ||
| for call_args in client.get_object.call_args_list: | ||
| self.assertEqual(call_args[1].get('RequestPayer'), 'requester') |
There was a problem hiding this comment.
Oh let's use the stubber for these and the expected_params. I have been using it lately. It's pretty handy and makes the test case much cleaner.
|
Looks good. Just had a comment on the test where we should try to use the stubber instead of mock for clients. |
|
Thanks! 🚢 |
rayluo
added
bug
|
|
jamesls
added
pr/ready-to-merge
rayluo
added a commit
that referenced
this pull request
Feb 22, 2016
…le-from-requester-paid-bucket The extra_args was not properly relayed within MultipartDownloader
rayluo
deleted the
fix-bug-when-downloading-large-file-from-requester-paid-bucket
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing the transfer download feature failure when downloading big file from a RequestPayer=requester bucket.