Add SOCKS proxy support #2081
Closed
Add SOCKS proxy support #2081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2081 +/- ##
===========================================
- Coverage 93.11% 93.03% -0.09%
===========================================
Files 60 60
Lines 11096 11136 +40
===========================================
+ Hits 10332 10360 +28
- Misses 764 776 +12
Continue to review full report at Codecov.
|
|
I have a need to access AWS endpoints over SOCKS5 proxy and I've tested this modification successfully in that environment. Are you still working on this PR, and is there anything I could help with? |
hnousiainen
added a commit
to hnousiainen/pghoard
that referenced
this pull request
Apr 21, 2021
Extend proxy support to s3 driver as well. Socks support requires botocore with boto/botocore#2081 merged.
vkantchev
added a commit
to vkantchev/botocore
that referenced
this pull request
Jun 14, 2021
|
Are you still working on this feature? Would you mind if I pick it up? |
|
@zhan9san please be my guest |
Closed
rdunklau
pushed a commit
to Aiven-Open/rohmu
that referenced
this pull request
Apr 27, 2022
Extend proxy support to s3 driver as well. Socks support requires botocore with boto/botocore#2081 merged.
rdunklau
pushed a commit
to Aiven-Open/rohmu
that referenced
this pull request
Apr 27, 2022
Extend proxy support to s3 driver as well. Socks support requires botocore with boto/botocore#2081 merged.
rdunklau
pushed a commit
to Aiven-Open/rohmu
that referenced
this pull request
Apr 27, 2022
Extend proxy support to s3 driver as well. Socks support requires botocore with boto/botocore#2081 merged.
rdunklau
pushed a commit
to Aiven-Open/rohmu
that referenced
this pull request
Apr 27, 2022
Extend proxy support to s3 driver as well. Socks support requires botocore with boto/botocore#2081 merged.
juha-aiven
pushed a commit
to Aiven-Open/rohmu
that referenced
this pull request
Apr 27, 2022
Extend proxy support to s3 driver as well. Socks support requires botocore with boto/botocore#2081 merged.
juha-aiven
pushed a commit
to Aiven-Open/rohmu
that referenced
this pull request
Apr 27, 2022
Extend proxy support to s3 driver as well. Socks support requires botocore with boto/botocore#2081 merged.
alexole
pushed a commit
to Aiven-Open/rohmu
that referenced
this pull request
Apr 27, 2022
Extend proxy support to s3 driver as well. Socks support requires botocore with boto/botocore#2081 merged.
rdunklau
pushed a commit
to Aiven-Open/rohmu
that referenced
this pull request
Apr 27, 2022
Extend proxy support to s3 driver as well. Socks support requires botocore with boto/botocore#2081 merged.
|
Thank you for creating this PR. After bringing this up for discussion with the team we decided to continue tracking this request in #2541 going forward, with the latest update here: #2541 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although this "works for me", it's still work in progress and needs at least some more tests in
test_http_session.pyto cover cases whereURLLib3Sessionis configured with SOCKS proxies. Before going any further I wanted to verify the general approach.One particular question is how to avoid warnings from importing
urlib3.contrib.sockswhensocks(an optional dependency) is not available.