Support for sdk_ua_app_id config setting #2942
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
AWS_SDK_UA_APP_ID
environment variable andsdk_ua_app_id
setting in the shared configuration file. This is already supported by some other AWS SDKs today and will in future be the recommended way for third party apps that use botocore to inject an identifier into the User-Agent header. Botocore will also continue supporting theuser_agent
anduser_agent_extra
config settings for backwards compatibility.For test coverage, this PR introduces new functional testing for all user agent header related config settings. While there are existing tests for user agent settings in unit/test_client.py, unit/test_session.py, and unit/test_session_legacy.py, they either test session-level settings (which get overridden or modified by client-level config) or mock the legacy endpoint resolver.
Open questions where for which I'd be particularly interested to hear feedback: