Move urllib3 2.x pin for Python 3.10+ #3141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3141 +/- ##
========================================
Coverage 93.14% 93.14%
========================================
Files 66 66
Lines 14237 14240 +3
========================================
+ Hits 13261 13264 +3
Misses 976 976 ☔ View full report in Codecov by Sentry. |
SamRemis
approved these changes
Mar 14, 2024
hswong3i
pushed a commit
to alvistack/boto-botocore
that referenced
this pull request
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will move our pin for Python 3.10+ to allow the full range of releases for urllib3 2.x. This should unblock further upgrades and unblock other projects from moving pins for these version ranges. This should resolve #3138 in the next release of Botocore once merged.